Redesign footer with contract, token, and GitHub links#452
Merged
realproject7 merged 1 commit intomainfrom Mar 23, 2026
Merged
Conversation
- Remove Stories and Create links (already in NavBar) - Add StoryFactory contract address with Basescan link - Add $PLOT link to /token page - Update GitHub link to plotlink-contracts repo Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
approved these changes
Mar 23, 2026
Collaborator
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
T2b Review — APPROVE
Reviewed: src/components/Footer.tsx (1 file, +16/-6)
Checklist
| # | Check | Result |
|---|---|---|
| 1 | Footer content — correct links | PASS — Contract links to Basescan via EXPLORER_URL, $PLOT links to /token, GitHub links to plotlink-contracts repo |
| 2 | Removed duplicate Stories/Create links | PASS — Both <Link href="/">stories</Link> and <Link href="/create">create</Link> removed (already in NavBar) |
| 3 | Contract address links to correct Basescan URL | PASS — Uses EXPLORER_URL + /address/ + STORY_FACTORY from constants. Supports testnet (sepolia.basescan.org) and mainnet (basescan.org) automatically |
| 4 | No hardcoded values that should be constants | PASS — Contract address and explorer URL imported from lib/contracts/constants. GitHub URL is a static string constant at module scope — acceptable since it has no env-dependent variant |
| 5 | Clean responsive layout | PASS — Existing flex-wrap + gap-4 structure preserved. No layout changes needed |
| 6 | Security | PASS — External links use target="_blank" rel="noopener noreferrer". No user input, no secrets exposed |
| 7 | Code quality | PASS — Clean diff. title={STORY_FACTORY} on the contract link shows full address on hover. Truncation via slice(0,6)...slice(-4) follows standard wallet-address display convention |
Notes
- Good use of the existing
STORY_FACTORYandEXPLORER_URLconstants — the footer will automatically switch between testnet/mainnet Basescan URLs based onNEXT_PUBLIC_CHAIN_ID. - The
GITHUB_URLconstant is defined at module scope rather than inline — clean approach. - Import path
../../lib/contracts/constantsis consistent with the project's existing convention (lib/ sits at repo root, components are in src/).
No issues found. Clean, minimal change that does exactly what the issue requested.
project7-interns
approved these changes
Mar 23, 2026
Collaborator
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
T2b Review: PR #452 — Footer Redesign
APPROVED ✅
- Contract address links correctly via
EXPLORER_URL+STORY_FACTORYconstants (auto-switches testnet/mainnet) - $PLOT links to /token, GitHub to plotlink-contracts repo
- Duplicate Stories/Create links properly removed
- External links have
target="_blank" rel="noopener noreferrer" - Address truncation follows standard convention (
slice(0,6)...slice(-4)) - Clean minimal diff (+16/-6), no hardcoded values
project7-interns
approved these changes
Mar 23, 2026
Collaborator
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The footer redesign is clean, narrowly scoped, and now passes checks. The link targets and scope match the requested footer cleanup.
Findings
- [resolved] Footer links and cleanup are correct.
- File:
src/components/Footer.tsx:1 - Suggestion: None.
- File:
Decision
Approving because the change is correct and CI is green.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/tokenpageFixes #254
Test plan
next buildpasses🤖 Generated with Claude Code